-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all harmony flags #1885
Conversation
cc @mochajs/mocha Worth pushing for a patch release? :) |
SGTM |
Support all harmony flags
Thank you @danielstjules for great patch! |
Hoping we might get a patch release out this week! :) |
Amazing, I was just looking for it to be able to use |
I know we've moved on - but thought it interesting when I came across this thread just now and how the coffee folks dealt with the node.js flags |
Interesting. I know |
Happy to keep discussing this in #1846 :) I don't think we've moved on at all. I just hid the duct tape haha |
--harmony-async-await ? (for anybody trying to find) Edit: |
Rel: #1846
This solution doesn't break the existing API - it only improves on our current situation. Rather than have to add flags to both
bin/_mocha
andbin/mocha
each time they're introduced and publish a patch release, we'll automatically support all flags of the form--harmony*
This also has the advantage of being less error prone, as some flags were supported inmocha
, but not listed in_mocha
and thus weren't visible via--help
.Finally,
--help
output will be quite a bit cleaner. Node 4.0.0 includes a few other flags we'd have to add otherwise: