test fallback to ChromeCanary/Chromium/PhantomJS in macOS #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
the config lacks context about why Chrome is the default. it's the default because at the time of the change, PhantomJS v1.9.8 was causing seg faults. But...I can no longer reproduce the seg fault. It's likely the executable or macOS has been fixed in the meantime. So PhantomJS should be the default across all OS's. So, while we can't accept this PR--because the conditional should be removed altogether (which I'm about to do)--we can accept a PR in the future that adds support for headless Chrome, or make it easier for users to specify which browser (ChromeCanary, etc) they want to launch via the command line. That could start with ditching |
boneskull
added a commit
that referenced
this pull request
May 9, 2017
- also, reformat a conditional ariya/phantomjs#14558 was causing seg faults at the time this change was made; it is no longer causing seg faults, so phantomjs should be the default. this was prompted by #2759
boneskull
added a commit
that referenced
this pull request
May 12, 2017
- also, reformat a conditional ariya/phantomjs#14558 was causing seg faults at the time this change was made; it is no longer causing seg faults, so phantomjs should be the default. this was prompted by #2759
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
- also, reformat a conditional ariya/phantomjs#14558 was causing seg faults at the time this change was made; it is no longer causing seg faults, so phantomjs should be the default. this was prompted by mochajs#2759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.