Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all after hooks are executed, even if one of them fail #3488

Closed

Conversation

johanblumenberg
Copy link

Reopening this PR: #3281
See the details and discussion in the referenced PR.

@johanblumenberg johanblumenberg changed the title Invoke all hooks Ensure all after hooks are executed, even if one of them fail Oct 4, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 90.263% when pulling bd90921 on johanblumenberg:invoke-all-hooks into 04469bf on mochajs:master.

@outsideris outsideris added type: feature enhancement proposal semver-major implementation requires increase of "major" version number; "breaking changes" labels Oct 21, 2018
@johanblumenberg
Copy link
Author

The first commit in this PR also fixes the issue pointed out by this comment:

// XXX how about a less awful way to determine this?

@plroebuck
Copy link
Contributor

We're not going back to assert -- use unexpected in your tests.
Won't recommend for review until merge conflicts are fixed, just so we're not wasting anyone's time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major implementation requires increase of "major" version number; "breaking changes" stale this has been inactive for a while... type: feature enhancement proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants