-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manage author list in AUTHORS instead package.json #4058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per boneskull's comment
ensure the AUTHORS file is written to at publish time
above part is missing.
34d833c
to
5486dc5
Compare
I updated to run |
I also updated maintainer's guide for releasing. |
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
ab33494
to
3d36c93
Compare
Anyway, I rebased this onto master and updated AUTHORS. |
Signed-off-by: Outsider <outsideris@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outsideris thank you, lgtm.
Currently, the contributor list managed in
package.json
. However, it is too long.So, we moved the list into
AUTHORS
update-authors.js
updated to fit mocha.(originalupdate-authors.js
comes from Node's scripts)AUTHORS
made based on v6.2.1. It's latest list.close #4053