do not commit generated content to VCS; closes #3713 #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
semver-patch
boneskull
force-pushed
the
boneskull/issue/3713
branch
from
e0754bb
to
899b3a0
Compare
boneskull
force-pushed
the
boneskull/issue/3713
branch
from
899b3a0
to
0388875
Compare
Munter
approved these changes
May 16, 2020
This removes `markdown-magic` and replaces its functionality with the built-in data capabilities of 11ty. The TOC, `--help` output, and source files are now all done via global data scripts in `docs/_data`. When building documentation, we will no longer get changes to e.g., `docs/index.md` because of the automatically generated content.
Usage of the words as defined in options will result in a warning, and will not break the build. Also: Eleventy should ignore the historical changelogs in `docs/changelogs`.
boneskull
force-pushed
the
boneskull/issue/3713
branch
from
b243f24
to
4d7e86e
Compare
|
I added an official eleventy plugin which detects usages of words like "simply", "obviously", etc., which don't only make the reader feel stupid, but are often straight-up bad writing 😄 It emits warnings at build time and will not break the build. |
|
I've confirmed the build has passed for real with my eyeballs, so merging |
craigtaub
pushed a commit
that referenced
this pull request
May 21, 2020
* do not commit generated content to VCS This removes `markdown-magic` and replaces its functionality with the built-in data capabilities of 11ty. The TOC, `--help` output, and source files are now all done via global data scripts in `docs/_data`. When building documentation, we will no longer get changes to e.g., `docs/index.md` because of the automatically generated content. * add inclusive language plugin to eleventy Usage of the words as defined in options will result in a warning, and will not break the build. Also: Eleventy should ignore the historical changelogs in `docs/changelogs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
markdown-magicand replaces its functionality with the built-in data capabilities of 11ty.The TOC,
--helpoutput, and source files are now all done via global data scripts indocs/_data.When building documentation, we will no longer get changes to e.g.,
docs/index.mdbecause of the automatically generated content.