Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move removal of uncaughtException handler into end callback #4329

Closed
wants to merge 1 commit into from
Closed

Move removal of uncaughtException handler into end callback #4329

wants to merge 1 commit into from

Commits on Jun 10, 2020

  1. Move removal of uncaughtException handler into end callback 

    And only attach it initially within `start`. Since `self.uncaught` is a bound function, "removing" it immediately before adding it only prevents the same instance from leaking multiple handles - it still allows multiple runners to leak handles forever, even when those runners are ended (resulting in an issue akin to mochajs#4144).
    @weswigham
    weswigham authored Jun 10, 2020
    Configuration menu
    Copy the full SHA
    b281628 View commit details
    Browse the repository at this point in the history