Remove unused and incorrect test.retries(n)
#4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
added
qa
semver-patch
juergba
force-pushed
the
juergba/retries
branch
from
02004e3
to
dd637af
Compare
juergba
requested review from
boneskull and
a team
and removed request for
boneskull
outsideris
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We remove
test.retries(n)from our interfacescommon,bdd,tdd,qunit.This function has never been used/implemented correctly as shown by coverall's excited reaction. Furthermore the signature is weird and somewhat incomplete.
This PR does not affect:
this.retries(n)withinsuites andtestsit(title, fn).retries(n)