fix/improve typing in the example #47
Conversation
| ): | ||
| ble_uuid = device["ble_uuid"] | ||
| for sesame_uuid, sesame_device in connected_devices.items(): | ||
| if sesame_device.device.getDeviceStatus().value == CHDeviceLoginStatus.UnLogin: # type: ignore |
There was a problem hiding this comment.
I got complained about value is unknown. Not sure how to fix typings for aenum, so I ignored it :(
There is an open issue about aenum typing: ethanfurman/aenum#10, the error is not exact the same here though.
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 8 8
Lines 1133 1133
=======================================
Hits 1064 1064
Misses 69 69 Continue to review full report at Codecov.
|
|
Hi @zhyu, nice catch and happy to see your first contribution! 🎉 As you pointed out, I did not spend much time for typing in the sample scripts and your contribution is much appreciated. I just created #52 based on the latest master code and your contribution. Can you take a look and double-check there is no typing problem? Thank you! |
2 participants
Hi, thanks for making this nice library!
I found several typing issues while playing with the example. This PR contains my fixes.