Move the matrix computations to their own file #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
eggrobin
approved these changes
Jan 9, 2022
numerics/fixed_arrays.hpp
Outdated
| explicit Row(Matrix& matrix, int row); | ||
|
|
||
| // We need to remove the const because, when this class is instantiated with | ||
| // 'FixedUpperTriangularMatrix const', the first operator[], not the second, |
numerics/matrix_computations.hpp
Outdated
| template<typename U> | ||
| struct CholeskyGenerator; | ||
|
|
||
| template<typename Scalar_, template<typename S> typename UpperTriangularMatrix> |
There was a problem hiding this comment.
Move the definition of the generators to the _body so that this file remains easy to skim.
eggrobin
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make them usable on both
FixedandUnboundedmatrices. Also some minor improvements:operator<<forFixedarrays.FixedLowerTriangularMatrix.Fixedarrays.This PR also changes the macOS minimum version to 10.14 (Mojave).