Handle null in argument matchers.
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stubbing with argument matchers, the following
scenario would cause a NullPointerException:
```
whenever(mock.doSomething(argThat { })).thenReturn("")
whenever(mock.doSomething(argThat { })).thenReturn("")
```
The second `argThat` invocation returns a `null` value,
which gets propagated into the function passed to the
first `argThat` invocation.
This commit filters `null` values to always evaluate to
`false` when provided to an argument matcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stubbing with argument matchers, the following
scenario would cause a NullPointerException:
whenever(mock.doSomething(argThat { })).thenReturn("") whenever(mock.doSomething(argThat { })).thenReturn("")The second
argThatinvocation returns anullvalue,which gets propagated into the function passed to the
first
argThatinvocation.This commit filters
nullvalues to always evaluate tofalsewhen provided to an argument matcher.Fixes #133.
Fixes #134 by throwing a descriptive error.