Prevent kover setup failure without Android SDK #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, thanks for looking into this! |
renovate bot
referenced
this pull request
in kotest/kotest
Feb 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.mockk:mockk](https://mockk.io) ([source](https://togithub.com/mockk/mockk)) | `1.13.7` -> `1.13.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mockk/mockk (io.mockk:mockk)</summary> ### [`v1.13.9`](https://togithub.com/mockk/mockk/releases/tag/1.13.9) [Compare Source](https://togithub.com/mockk/mockk/compare/1.13.8...1.13.9) #### What's Changed - Remove AllOpen plugin from Android libraries by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1164](https://togithub.com/mockk/mockk/pull/1164) - Enforce reproducible builds by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1162](https://togithub.com/mockk/mockk/pull/1162) - Fix unit tests errors by using `slf4jOrJulLogging()` by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1166](https://togithub.com/mockk/mockk/pull/1166) - Remove KAPT from Android libraries by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1163](https://togithub.com/mockk/mockk/pull/1163) - JVM 1.8 source compatibility by [@​jeffdgr8](https://togithub.com/jeffdgr8) in [https://github.com/mockk/mockk/pull/1161](https://togithub.com/mockk/mockk/pull/1161) - Specify unique `android.namespace` to resolve warnings by [@​kubode](https://togithub.com/kubode) in [https://github.com/mockk/mockk/pull/1181](https://togithub.com/mockk/mockk/pull/1181) - Add scoped mock documentation by [@​kshired](https://togithub.com/kshired) in [https://github.com/mockk/mockk/pull/1175](https://togithub.com/mockk/mockk/pull/1175) - Upgrade Gradle to 8.4 by [@​geekiyer](https://togithub.com/geekiyer) in [https://github.com/mockk/mockk/pull/1184](https://togithub.com/mockk/mockk/pull/1184) - Fixes infinite recursion when stubbing a fun that returns value class by [@​OitoH](https://togithub.com/OitoH) in [https://github.com/mockk/mockk/pull/1176](https://togithub.com/mockk/mockk/pull/1176) - Prevent kover setup failure without Android SDK by [@​milgner](https://togithub.com/milgner) in [https://github.com/mockk/mockk/pull/1193](https://togithub.com/mockk/mockk/pull/1193) - Support value classes for non-primitive types by [@​milgner](https://togithub.com/milgner) in [https://github.com/mockk/mockk/pull/1192](https://togithub.com/mockk/mockk/pull/1192) - Fix StackOverflowError calling method on spy of class with generic base class by [@​flapenna](https://togithub.com/flapenna) in [https://github.com/mockk/mockk/pull/1195](https://togithub.com/mockk/mockk/pull/1195) #### New Contributors - [@​jeffdgr8](https://togithub.com/jeffdgr8) made their first contribution in [https://github.com/mockk/mockk/pull/1161](https://togithub.com/mockk/mockk/pull/1161) - [@​kshired](https://togithub.com/kshired) made their first contribution in [https://github.com/mockk/mockk/pull/1175](https://togithub.com/mockk/mockk/pull/1175) - [@​OitoH](https://togithub.com/OitoH) made their first contribution in [https://github.com/mockk/mockk/pull/1176](https://togithub.com/mockk/mockk/pull/1176) - [@​flapenna](https://togithub.com/flapenna) made their first contribution in [https://github.com/mockk/mockk/pull/1195](https://togithub.com/mockk/mockk/pull/1195) **Full Changelog**: mockk/mockk@1.13.8...1.13.9 ### [`v1.13.8`](https://togithub.com/mockk/mockk/releases/tag/1.13.8) [Compare Source](https://togithub.com/mockk/mockk/compare/1.13.7...1.13.8) #### What's Changed - Bump googleapis from 20.2.0 to 59.0.0 in /cloud-badge by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/mockk/mockk/pull/482](https://togithub.com/mockk/mockk/pull/482) - Minor performance improvements to MockInjector by [@​k163377](https://togithub.com/k163377) in [https://github.com/mockk/mockk/pull/1134](https://togithub.com/mockk/mockk/pull/1134) - Improve log message by [@​marcelstoer](https://togithub.com/marcelstoer) in [https://github.com/mockk/mockk/pull/1117](https://togithub.com/mockk/mockk/pull/1117) - Update README.md by [@​iainism](https://togithub.com/iainism) in [https://github.com/mockk/mockk/pull/1140](https://togithub.com/mockk/mockk/pull/1140) - Update Android test targets by [@​LeonRa](https://togithub.com/LeonRa) in [https://github.com/mockk/mockk/pull/1146](https://togithub.com/mockk/mockk/pull/1146) - Fix `IncompatibleClassChangeError` in Android instrumentation test ([#​1035](https://togithub.com/mockk/mockk/issues/1035)) by [@​LeonRa](https://togithub.com/LeonRa) in [https://github.com/mockk/mockk/pull/1145](https://togithub.com/mockk/mockk/pull/1145) - Update Gradle and Android dependencies by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1105](https://togithub.com/mockk/mockk/pull/1105) - Update byte-buddy 1.14.6 by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1149](https://togithub.com/mockk/mockk/pull/1149) - Remove unused `androidTools` in `Deps.kt` by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1150](https://togithub.com/mockk/mockk/pull/1150) - Update Kotlin 1.9.10 by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1148](https://togithub.com/mockk/mockk/pull/1148) - Update KotlinX Kover 0.7.3 by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1152](https://togithub.com/mockk/mockk/pull/1152) - Remove Kotlin-IR from CI matrix by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1153](https://togithub.com/mockk/mockk/pull/1153) - Update Dokka 1.9.0 by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1151](https://togithub.com/mockk/mockk/pull/1151) - Fix Kotlin version override in tests by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1154](https://togithub.com/mockk/mockk/pull/1154) - Use new Kotlin logo by [@​Goooler](https://togithub.com/Goooler) in [https://github.com/mockk/mockk/pull/1156](https://togithub.com/mockk/mockk/pull/1156) - Swap expected/actual in `KotlinVersionOverrideTest.kt` by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1157](https://togithub.com/mockk/mockk/pull/1157) - Reduce the use of spread operator to improve performance by [@​k163377](https://togithub.com/k163377) in [https://github.com/mockk/mockk/pull/1143](https://togithub.com/mockk/mockk/pull/1143) - update Kotlin and Java Toolchain properties, and setting them in CI by [@​aSemy](https://togithub.com/aSemy) in [https://github.com/mockk/mockk/pull/1056](https://togithub.com/mockk/mockk/pull/1056) - Fix `dokkaJavadoc` publishing task by [@​SimonMarquis](https://togithub.com/SimonMarquis) in [https://github.com/mockk/mockk/pull/1160](https://togithub.com/mockk/mockk/pull/1160) #### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/mockk/mockk/pull/482](https://togithub.com/mockk/mockk/pull/482) - [@​k163377](https://togithub.com/k163377) made their first contribution in [https://github.com/mockk/mockk/pull/1134](https://togithub.com/mockk/mockk/pull/1134) - [@​marcelstoer](https://togithub.com/marcelstoer) made their first contribution in [https://github.com/mockk/mockk/pull/1117](https://togithub.com/mockk/mockk/pull/1117) - [@​LeonRa](https://togithub.com/LeonRa) made their first contribution in [https://github.com/mockk/mockk/pull/1146](https://togithub.com/mockk/mockk/pull/1146) **Full Changelog**: mockk/mockk@1.13.7...1.13.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kotest/kotest). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1191
Not a particularly nice solution but unfortunately type safe project access doesn't like mentioning non-existing projects at all - which is okay since that's what it was built for.
Afaik there isn't any check whether a constant is defined in Kotlin script, so I had to resort to a more traditional approach... 😬