Skip to content

Conversation

rwjblue-glean
Copy link
Contributor

Motivation and Context

I noticed that some of the files weren't formatted (go fmt left dirty files on main), so I went ahead and added a lint CI job. We can add more linting things later if folks want, but validating formatting seemed like a nice first step.

I pushed a separate commit with go fmt ./... ran alone (just to make it clear what was automated changes vs manual ones).

How Has This Been Tested?

N/A

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@rwjblue-glean rwjblue-glean changed the title Rwjblue/go fmt ci feat(ci): Add go fmt check to CI workflow Jun 25, 2025
@rwjblue-glean rwjblue-glean changed the title feat(ci): Add go fmt check to CI workflow feat(ci): Add check to ensure go fmt has been ran Jun 25, 2025
@findleyr
Copy link
Contributor

Thanks! We're actually pretty naive to GitHub actions (we have our own CI system for the Go project). Much appreciated.

@findleyr findleyr merged commit 057f525 into modelcontextprotocol:main Jun 25, 2025
3 checks passed
@rwjblue-glean rwjblue-glean deleted the rwjblue/go-fmt-ci branch June 25, 2025 19:32
@rwjblue-glean
Copy link
Contributor Author

I've done a ton with GHA over the years, happy to help add anything y'all find useful (e.g. golangci-lint setup).

@jba jba mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants