Skip to content

Conversation

MegaGrindStone
Copy link
Contributor

Motivation and Context

In both examples, the tools returns the parameter name instead the value of the parameter. No matter what client input as Name, the tool result always returns: Hi greet.

This PR fixes it by returning the Name from the arguments.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Contributor

@findleyr findleyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@findleyr findleyr merged commit 10dcf48 into modelcontextprotocol:main Jun 25, 2025
3 checks passed
@jba jba mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants