Skip to content

jsonschema: unexport ForType #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

jsonschema: unexport ForType #71

merged 2 commits into from
Jun 30, 2025

Conversation

jba
Copy link
Contributor

@jba jba commented Jun 29, 2025

There's no evidence that it's needed.

Also, improve doc and error messages.

@jba
jsonschema: unexport ForType
1378f27 
There's no evidence that it's needed.

Also, improve doc and error messages.
@jba jba requested a review from findleyr June 29, 2025 12:51
findleyr
findleyr previously approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@findleyr findleyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jba
Copy link
Contributor Author

jba commented Jun 30, 2025

needs re-approval

@jba jba enabled auto-merge (squash) June 30, 2025 17:58
@jba jba merged commit 2facfc6 into modelcontextprotocol:main Jun 30, 2025
3 checks passed
@jba jba mentioned this pull request Jul 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samthanawalla samthanawalla samthanawalla approved these changes

@findleyr findleyr findleyr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jba @samthanawalla @findleyr