Fix cli package.json import #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed that reads package.json from one level up. It works if the project is checked out locally, but not in the npm package, because the package.json of the workspace packages is not included in the inspector package. We can get that from one level up, the inpsector's own package, and so this change does that.
…lcontextprotocol/inspector or @modelcontextprotocol/inspector-cli the location of package.json will either be in ../ or ../../ * In cli/src/index.ts - load package.json from the parent folder or parent's parent depending on file existence in parent. - move the load of package.json into callMethod function, which is the only place it is used, and is closer to where it is referenced.
|
For those looking for a temporary fix, you can use |
|
Thanks @cliffhall , I'll look at adding a test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cli/src/index.tspackage.jsonfrom../or../../depending on file existence in parent.package.jsonintocallMethodfunction, which is the only place it is used, and is closer to where it is referenced.Motivation and Context
In #544, a change to
cli/src/index.tswas introduced that readspackage.jsonfrom one level up (../package.json). As reported in #834, It fails when running@modelcontextprotocol/inspectorfrom the command line.package.jsonof the workspace packages are present.inspectorbuild, so it does not work in@modelcontextprotocol/inspector.../../package.json) the in main inspector package.@modelcontextprotocol/inspector-cli, the location of the workspace'spackage.jsonwill be in../and../../package.jsonwill not exist.Therefore, this PR reads
../package.jsonif present, otherwise it reads../../package.json. One of the two will exist.Location of
index.jsin maininspectorpackageNo
package.jsonin../Present at
../../package.jsonLocation of
index.jsininspector-clipackagePresent at
../package.jsonHow Has This Been Tested?
Locally, running a CLI command
node cli/build/cli.js --cli https://mcp.paypal.com/mcp --transport http --method tools/list --header "Authorization: Bearer <token>"This is a problem that we only saw once published, but given the above known locations of the
package.jsonin either published package, I'm confident it will work as expected. All tests still pass.Breaking Changes
Nope.
Types of changes
Checklist
Additional context
Fixes #834