Skip to content

Conversation

pascalconfluent
Copy link

Motivation and Context

It allows to support resource template as the sdk already supports resources

How Has This Been Tested?

Wrote unit tests

Breaking Changes

I don't think so

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [XI have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@pascalconfluent pascalconfluent marked this pull request as draft March 3, 2025 14:52
@pascalconfluent pascalconfluent marked this pull request as ready for review March 3, 2025 18:21
@pascalconfluent
Copy link
Author

@tzolov any hope to have this PR reviewed? Let me know if I can do anything to help if needed :)

Thank you so much!

@chemicL
Copy link
Member

chemicL commented Mar 4, 2025

Thank you for the PR. We are currently refactoring the internals a bit to address #9. The PR will probably have to adapt to the new mode of operation. I'll keep you updated.

@tzolov
Copy link
Contributor

tzolov commented Mar 27, 2025

@pascalconfluent , thank your patience.
After the 0.8.x refactoring is complete, could you please rebase your PR on top of main and resolve the possible conflicts.

@pascalconfluent
Copy link
Author

@tzolov Done! Let me know if I should change anything.

Thank you!

@tzolov
Copy link
Contributor

tzolov commented Apr 2, 2025

Thanks you! Will review it over the weekend

@pascalconfluent
Copy link
Author

@tzolov Any update on this PR?

@chemicL
Copy link
Member

chemicL commented Apr 23, 2025

@pascalconfluent I noticed commented out tests - is this PR a work in progress or was that an accidental omission?

@chemicL chemicL added the waiting for user Waiting for user feedback or more details label Apr 23, 2025
@noear
Copy link

noear commented May 10, 2025

This pr is much needed!

@tzolov
Copy link
Contributor

tzolov commented Sep 25, 2025

Hi @pascalconfluent, thanks for addressing this.

I finally had time to investigate this issue, and it's more involving than expected.

Our current Resource handling supports both static and template URIs, but this isn't spec-compliant since the spec splits (unnecessarily IMO) these into separate entities (Resource and ResourceTemplate).

Your approach is correct, but due to breaking changes and new transport/server modes, I had to rework it in #576. Could you review it and add any missing bits or tests?

I'd like to make you co-author of #576 if you're agreeable.

@tzolov
Copy link
Contributor

tzolov commented Sep 28, 2025

@pascalconfluent we've merged #576 (with you as co-author). It extends your PR with:

  • Support for stateless servers
  • Enhanced read-resource and auto-completion logic using resource-templates
  • Extended runtime resource/resource-template management (list capabilities + replace-on-duplicate logic)

One difference: we're using Map<String, AsyncResourceTemplateSpecification> instead of Map<UriTemplate, AsyncResourceTemplateSpecification> for resourceTemplates, relying on existing McpUriTemplateManagerFactory/McpUriTemplateManager.

Any concerns with UriTemplate vs McpUriTemplateManager implementations? Feel free to open a follow-up PR if needed.

@tzolov tzolov added this to the 0.14.0 milestone Sep 28, 2025
@tzolov tzolov removed the waiting for user Waiting for user feedback or more details label Sep 28, 2025
@tzolov
Copy link
Contributor

tzolov commented Sep 28, 2025

Closing this PR as replaced by #576 .
Feel free to re-open if something is missing

@tzolov tzolov closed this Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants