-
Notifications
You must be signed in to change notification settings - Fork 682
Adding support for resource template #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for resource template #25
Conversation
refactor(mcp): remove redundant type field from Content implementatio…
@tzolov any hope to have this PR reviewed? Let me know if I can do anything to help if needed :) Thank you so much! |
Thank you for the PR. We are currently refactoring the internals a bit to address #9. The PR will probably have to adapt to the new mode of operation. I'll keep you updated. |
@pascalconfluent , thank your patience. |
@tzolov Done! Let me know if I should change anything. Thank you! |
Thanks you! Will review it over the weekend |
@tzolov Any update on this PR? |
@pascalconfluent I noticed commented out tests - is this PR a work in progress or was that an accidental omission? |
This pr is much needed! |
Hi @pascalconfluent, thanks for addressing this. I finally had time to investigate this issue, and it's more involving than expected. Our current Resource handling supports both static and template URIs, but this isn't spec-compliant since the spec splits (unnecessarily IMO) these into separate entities (Resource and ResourceTemplate). Your approach is correct, but due to breaking changes and new transport/server modes, I had to rework it in #576. Could you review it and add any missing bits or tests? I'd like to make you co-author of #576 if you're agreeable. |
@pascalconfluent we've merged #576 (with you as co-author). It extends your PR with:
One difference: we're using Any concerns with UriTemplate vs McpUriTemplateManager implementations? Feel free to open a follow-up PR if needed. |
Closing this PR as replaced by #576 . |
Motivation and Context
It allows to support resource template as the sdk already supports resources
How Has This Been Tested?
Wrote unit tests
Breaking Changes
I don't think so
Types of changes
Checklist
Additional context