Skip to content

refactor: change int to Integer for optional numeric fields #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+4 −4
Merged

refactor: change int to Integer for optional numeric fields #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mcp-core/src/main/java/io/modelcontextprotocol/spec/McpSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ public record JSONRPCResponse( // @formatter:off
@JsonInclude(JsonInclude.Include.NON_ABSENT)
@JsonIgnoreProperties(ignoreUnknown = true)
public record JSONRPCError( // @formatter:off
@JsonProperty("code") int code,
@JsonProperty("code") Integer code,
@JsonProperty("message") String message,
@JsonProperty("data") Object data) { // @formatter:on
}
Expand Down Expand Up @@ -1822,14 +1822,14 @@ public record CreateMessageRequest( // @formatter:off
@JsonProperty("systemPrompt") String systemPrompt,
@JsonProperty("includeContext") ContextInclusionStrategy includeContext,
@JsonProperty("temperature") Double temperature,
@JsonProperty("maxTokens") int maxTokens,
@JsonProperty("maxTokens") Integer maxTokens,
@JsonProperty("stopSequences") List<String> stopSequences,
@JsonProperty("metadata") Map<String, Object> metadata,
@JsonProperty("_meta") Map<String, Object> meta) implements Request { // @formatter:on

// backwards compatibility constructor
public CreateMessageRequest(List<SamplingMessage> messages, ModelPreferences modelPreferences,
String systemPrompt, ContextInclusionStrategy includeContext, Double temperature, int maxTokens,
String systemPrompt, ContextInclusionStrategy includeContext, Double temperature, Integer maxTokens,
List<String> stopSequences, Map<String, Object> metadata) {
this(messages, modelPreferences, systemPrompt, includeContext, temperature, maxTokens, stopSequences,
metadata, null);
Expand Down Expand Up @@ -1859,7 +1859,7 @@ public static class Builder {

private Double temperature;

private int maxTokens;
private Integer maxTokens;

private List<String> stopSequences;

Expand Down