-
Notifications
You must be signed in to change notification settings - Fork 160
Introduce Kotlin client/server <--> TypeScript client/server integration tests #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
devcrocod
merged 22 commits into
modelcontextprotocol:main
from
skarpovdev:skarpov/integration-tests
Sep 9, 2025
Merged
Introduce Kotlin client/server <--> TypeScript client/server integration tests #216
devcrocod
merged 22 commits into
modelcontextprotocol:main
from
skarpovdev:skarpov/integration-tests
Sep 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f03d15
to
f65c136
Compare
f65c136
to
acc50d3
Compare
4cc9638
to
6f86cd4
Compare
89aa914
to
cc3e79d
Compare
cc3e79d
to
6f9bf7c
Compare
@skarpovdev please take a look at a validation check |
a9b75c4
to
6f9bf7c
Compare
@devcrocod The test fails only in this branch because this is the only place where we actually run jvm tests that rely on JUnit 5. I fixed it along with the bug in #243 |
6f9bf7c
to
92ebcb9
Compare
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
4dd7e26
to
b881a26
Compare
devcrocod
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General requirement to run the tests (apart from the main requirements for running any code in the repo) is to have node.js installed. I don't see the need for a separate README.md, but let me know if you think it's needed.
setupTypeScriptSdk
we clone the latest head of TypeScript SDK and instal all the dependencies. I thought about using the released version by installing it with npm, but decided to run tests with the latest commits to help us find issues faster, before the new version is released.For TypeScript server I useDONE ✅simpleStreamableHttp
from examples. If there is a concern it will be changed and hence such usage better be avoided, it can easily be migrated into a separate file.Types of changes
Checklist
Additional context