Skip to content

Conversation

skarpovdev
Copy link
Contributor

@skarpovdev skarpovdev commented Aug 5, 2025

General requirement to run the tests (apart from the main requirements for running any code in the repo) is to have node.js installed. I don't see the need for a separate README.md, but let me know if you think it's needed.

  1. In setupTypeScriptSdk we clone the latest head of TypeScript SDK and instal all the dependencies. I thought about using the released version by installing it with npm, but decided to run tests with the latest commits to help us find issues faster, before the new version is released.
  2. I put edge cases coverage into separate test classes to keep the main integration tests easy to find and debug. Btw, this part is mostly done by Junie.
  3. For TypeScript server I use simpleStreamableHttp from examples. If there is a concern it will be changed and hence such usage better be avoided, it can easily be migrated into a separate file. DONE ✅
  4. Kotlin server is a custom implementation to allow for more thorough testing, pls take a closer look at it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch 2 times, most recently from 0f03d15 to f65c136 Compare August 5, 2025 17:36
@skarpovdev skarpovdev marked this pull request as ready for review August 5, 2025 18:14
@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch from f65c136 to acc50d3 Compare August 5, 2025 18:20
@devcrocod devcrocod self-requested a review August 6, 2025 08:37
@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch from 4cc9638 to 6f86cd4 Compare August 6, 2025 10:31
@devcrocod devcrocod force-pushed the skarpov/integration-tests branch from 89aa914 to cc3e79d Compare August 25, 2025 10:49
@devcrocod devcrocod force-pushed the skarpov/integration-tests branch from cc3e79d to 6f9bf7c Compare August 25, 2025 16:35
@devcrocod
Copy link
Contributor

@skarpovdev please take a look at a validation check

@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch from a9b75c4 to 6f9bf7c Compare August 28, 2025 16:21
@skarpovdev
Copy link
Contributor Author

skarpovdev commented Aug 28, 2025

@skarpovdev please take a look at a validation check

@devcrocod The test fails only in this branch because this is the only place where we actually run jvm tests that rely on JUnit 5. I fixed it along with the bug in #243

@skarpovdev skarpovdev force-pushed the skarpov/integration-tests branch from 6f9bf7c to 92ebcb9 Compare August 29, 2025 10:57
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
Signed-off-by: Sergey Karpov <sergey.karpov@jetbrains.com>
@devcrocod devcrocod force-pushed the skarpov/integration-tests branch from 4dd7e26 to b881a26 Compare September 9, 2025 11:55
Copy link
Contributor

@devcrocod devcrocod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devcrocod devcrocod merged commit c455974 into modelcontextprotocol:main Sep 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants