Skip to content

Conversation

devcrocod
Copy link
Contributor

  • drop unnecessary publish workflow for client and server
  • remove unworkable steps in the main publishing workflow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @devcrocod
Let's clean it up

@devcrocod devcrocod force-pushed the devcrocod/drop-publish-workflow branch from 3e1e37e to 2835fa9 Compare September 12, 2025 16:16
@devcrocod devcrocod marked this pull request as ready for review September 12, 2025 16:16
@Copilot Copilot AI review requested due to automatic review settings September 12, 2025 16:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR streamlines the GitHub Actions workflow configuration by removing an unnecessary separate workflow for client and server publishing and eliminating problematic steps from the main publishing workflow.

  • Removes the entire publish-client-and-server.yml workflow file that was redundant
  • Removes error handling and artifact upload steps from the main gradle-publish.yml workflow that were causing issues

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish-client-and-server.yml Complete removal of redundant workflow for client and server publishing
.github/workflows/gradle-publish.yml Removal of Central Portal error query step and JReleaser artifact upload step
Comments suppressed due to low confidence (1)

.github/workflows/gradle-publish.yml:1

  • The removed code was using basic authentication instead of bearer token authentication. The curl command uses 'Bearer $AUTH' header but AUTH contains base64-encoded credentials for basic auth. This authentication method mismatch could have caused the API calls to fail.
# This workflow uses actions that are not certified by GitHub.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@devcrocod devcrocod merged commit c7361e1 into main Sep 12, 2025
4 checks passed
@devcrocod devcrocod deleted the devcrocod/drop-publish-workflow branch September 12, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants