Skip to content

Refactor signing publications #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
+6 −9
Merged

Refactor signing publications #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions buildSrc/src/main/kotlin/mcp.publishing.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import com.vanniktech.maven.publish.MavenPublishBaseExtension

plugins {
`maven-publish`
id("com.vanniktech.maven.publish")
Expand All @@ -6,6 +8,7 @@ plugins {

mavenPublishing {
publishToMavenCentral(automaticRelease = true)
configureSigning(this)

pom {
name = project.name
Expand Down Expand Up @@ -42,13 +45,7 @@ mavenPublishing {
}
}

publishing {
repositories {
mavenLocal()
}
}

signing {
private fun Project.configureSigning(mavenPublishing: MavenPublishBaseExtension) {
val gpgKeyName = "GPG_SIGNING_KEY"
val gpgPassphraseName = "SIGNING_PASSPHRASE"
val signingKey = providers.environmentVariable(gpgKeyName)
Expand All @@ -57,7 +54,7 @@ signing {
.orElse(providers.gradleProperty(gpgPassphraseName))

if (signingKey.isPresent) {
useInMemoryPgpKeys(signingKey.get(), signingPassphrase.get())
sign(publishing.publications)
mavenPublishing.signAllPublications()
signing.useInMemoryPgpKeys(signingKey.get(), signingPassphrase.get())
Comment on lines +57 to +58
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of operations is incorrect. signing.useInMemoryPgpKeys() should be called before mavenPublishing.signAllPublications() to ensure the signing configuration is properly set up before attempting to sign publications.

Suggested change
mavenPublishing.signAllPublications()
signing.useInMemoryPgpKeys(signingKey.get(), signingPassphrase.get())
signing.useInMemoryPgpKeys(signingKey.get(), signingPassphrase.get())
mavenPublishing.signAllPublications()

Copilot uses AI. Check for mistakes.

}
}
Loading