Skip to content

Conversation

jclyne
Copy link
Contributor

@jclyne jclyne commented Sep 26, 2025

When pulling this project into a composite project, via IncludeBuild, the samples are not necessary nor probably desired. They also cause issues as a transitive dependency

Motivation and Context

Improves the ability to pull the SDK into a composite build

How Has This Been Tested?

yes, tested locally in a composite build

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

…ionally include the samples unless its the root project
@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 18:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR conditionally imports sample projects only when the current project is the root project, preventing unnecessary inclusion of samples when the SDK is used as a dependency in composite builds.

  • Adds a conditional check to only include sample builds when gradle.parent == null
  • Wraps the existing includeBuild statements for three sample projects in the conditional block

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thank you for the PR, @jclyne

@kpavlov kpavlov merged commit 0ed92f5 into modelcontextprotocol:main Sep 27, 2025
3 checks passed
@jclyne jclyne deleted the better-composite-build-support branch October 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants