Change sample server host from 0.0.0.0 to 127.0.0.1 #307
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bind the sample server to
0.0.0.0
by default as that exposes the server to anyone else on the local network.If anyone were to use these samples as staring points to build larger services, those servers would thus expose developers to attack immediately upon launch.
I'd prefer if we avoided that 😆
Motivation and Context
🔒 Security
How Has This Been Tested?
I haven't checked out the code locally to verify it works. All the editing to the code was done on GitHub.com
Breaking Changes
No.
Types of changes
Checklist
Additional context