Discussion: Should declare(strict_types=1) be adopted in a codebase?

[butschster]

Hey team! 👋

I've been working on some new features lately and noticed that we're not currently using declare(strict_types=1). I wanted to understand a current approach and the reasoning behind it before I continue with my development.

Questions

Current State:

• Is there a specific reason we're not using declare(strict_types=1) currently?
• Are there particular challenges or constraints that influenced this choice?

Future Direction:

• Do you have plans to introduce strict types in the future?
• Are there specific areas of the codebase where strict types might be more or less appropriate?

I want to make sure I'm following established conventions and understand the technical reasoning behind current approach. This will help me write code that's consistent with the team's standards and architectural decisions.

[lubian-eventit]

As this codebase follows symfonys codestyle I would assume, that strict types are not being enforced here. Although the styleguide does not mention it explicitly (https://symfony.com/doc/current/contributing/code/standards.html) the symfony codebase does not declare usage of strict_types.

[roxblnfk]

I would prefer to see a more modern coding style. If Symfony standards don't prohibit it, then let's do it.

[chr-hertel]

I'll bring it up again, but usually Symfony decided against using it - at least i'll try to document the reasoning here.

[chr-hertel]

There you go, quite fresh:
PHP-CS-Fixer/PHP-CS-Fixer#8877