Skip to content

Conversation

CodeWithKyrian
Copy link
Contributor

This PR introduces handler for completion/complete method through a new Completer and CompletionCompleteHandler. Completion logic has also been moved reflecting its broader scope across both prompts and resource templates.

What's Changed

  • Added CompletionCompleteHandler and wired it into JsonRpcHandler::make.
  • Moved Capability/Prompt/Completion to Capability/Completion.
  • Added Completer: resolves reference and provider, returns paged CompletionCompleteResult.
  • Updated Builder/Discoverer/examples/tests to new namespaces.
  • Removed complete() from PromptReference and ResourceTemplateReference.

Breaking Changes

No direct impact on the public API and usage.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks! 👍 Needs a rebase after #98 tho

@chr-hertel chr-hertel added the Server Issues & PRs related to the Server component label Oct 6, 2025
@CodeWithKyrian CodeWithKyrian force-pushed the feature/completion-complete-handler branch from 1ccdac4 to fc6bdf6 Compare October 6, 2025 22:54
@CodeWithKyrian CodeWithKyrian merged commit 4b91567 into modelcontextprotocol:main Oct 7, 2025
10 checks passed
@CodeWithKyrian CodeWithKyrian deleted the feature/completion-complete-handler branch October 7, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Server Issues & PRs related to the Server component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants