-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Issue 1379 patch - Fix MCP server OAuth not working with Visual Studio Code and others with extra grant_types #1380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1379 patch - Fix MCP server OAuth not working with Visual Studio Code and others with extra grant_types #1380
Conversation
This should solve #1379 |
overall looks good, please add a test to make sure we keep this behavior in any future refactors |
Thank you @pcarleton. Done in 3b7419e |
Hi just following up @pcarleton @ochafik is there anything else you need to merge this? Let me know happy to help. Thank you! |
This will be very appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
3b7419e
to
f983a04
Compare
@pcarleton thank you for the approval! Unfortunately there was a merge conflict due to main drift in the test class. I rebased to resolve, but you need to approve again. There were no changes since the previous approval. Thanks! |
Motivation and Context
Visual Studio Code MCP server (and others) inject other grant types in OAuth request that are superfluous and can be ignored. As long as
authorization_code
andrefresh_token
are present this should be sufficient to work without erroring out.How Has This Been Tested?
I tested this locally in Visual Studio Code itself, and was able to have OAuth work successfully with these changes.
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context