-
Notifications
You must be signed in to change notification settings - Fork 65
Update metaschema URI format in input_schema.rb #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dr03ramos
wants to merge
5
commits into
modelcontextprotocol:main
Choose a base branch
from
dr03ramos:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes modelcontextprotocol#131. Tested on Windows and Linux. Added a "file://" prefix to prevent the JSON library from not identifying the URI correctly.
atesgoral
reviewed
Sep 13, 2025
5 tasks
It would be helpful to add source code comments explaining what kind of issues on Windows environments the added logic is intended to address. It would also be preferable to add regression tests to |
…nd output schema validation
|
koic
reviewed
Sep 18, 2025
koic
reviewed
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a "file://" prefix to prevent the JSON library from not identifying the URI correctly.
Motivation and Context
Fixes #131. The lib wasn't working for STDIO servers on any Windows environment i tested.
How Has This Been Tested?
Tested on Windows and Linux.
(The issue was occuring only on Windows, but i wanted to see if it would break Linux and it didn't.
Breaking Changes
Not expected.
Types of changes
Checklist
Additional context