Add instructions support to MCP::Server
#87
Conversation
| if @configuration.protocol_version == "2024-11-05" && @instructions | ||
| message = "`instructions` supported by protocol version 2025-03-26 or higher" | ||
| raise ArgumentError, message | ||
| end |
There was a problem hiding this comment.
If accepting the instructions parameter with the older "2024-11-05" protocol version is considered preferable, this logic could be removed as it only introduces unnecessary complexity.
There was a problem hiding this comment.
In case there are picky clients that could error on unexpected properties, I think being safe (backwards compatible) is good here.
But are we doing this kind of check uniformly for all features? Is there a Ruby-friendly annotation technique we could adopt to start doing this more declaratively...
I'm happy with this change as it is, though.
There was a problem hiding this comment.
At some point, it would be ideal to enable declarative descriptions using a DSL instead of procedural ones.
The response of the `init` method can include `instructions`. https://modelcontextprotocol.io/specification/2025-06-18/basic/lifecycle `instructions` appear to be supported starting from the 2025-03-26 specification. - https://modelcontextprotocol.io/specification/2025-03-26/basic/lifecycle (supports `instructions`) - https://modelcontextprotocol.io/specification/2024-11-05/basic/lifecycle (does not support `instructions`) If `instructions` is used with an unsupported protocol version, an `ArgumentError` will be raised. As additional context, the TypeScript SDK also treats `instructions` as optional. https://github.com/modelcontextprotocol/typescript-sdk/blob/1.16.0/src/types.ts#L356-L361
koic
force-pushed
the
add_instructions_support_to_mcp_server
branch
from
e51e562 to
f6f064a
Compare
Motivation and Context
The response of the
initmethod can includeinstructions. https://modelcontextprotocol.io/specification/2025-06-18/basic/lifecycleinstructionsappear to be supported starting from the 2025-03-26 specification.instructions)instructions)If
instructionsis used with an unsupported protocol version, anArgumentErrorwill be raised.How Has This Been Tested?
Existing tests have been updated and new tests have been added.
Breaking Changes
None.
Types of changes
Checklist
Additional context
As additional context, the TypeScript SDK also treats
instructionsas optional. https://github.com/modelcontextprotocol/typescript-sdk/blob/1.16.0/src/types.ts#L356-L361