Allow clients to override client_name #469
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
gpeal
added a commit
to openai/codex
that referenced
this pull request
Oct 3, 2025
…vers (#4689) The `experimental_use_rmcp_client` flag is still useful to: 1. Toggle between stdio clients 2. Enable oauth beacuse we want to land modelcontextprotocol/rust-sdk#469, #4677, and binary signing before we enable it by default However, for no-auth http servers, there is only one option so we don't need the flag and it seems to be working pretty well.
alexhancock
approved these changes
Oct 3, 2025
Many MCP Servers use client_name for a variety of things including: * Whitelisting * Logos * Copy shown directly on the page * etc As a result, it's important for MCP Clients to be able to override the client name.
gpeal
force-pushed
the
gpeal/client_name
branch
from
1351011 to
f0e8d61
Compare
|
I have a separate commit for the spellcheck fix on #470 Merging this in the interest of time despite the failing conventional commit check |
Merged
thomast8
pushed a commit
to thomast8/codex
that referenced
this pull request
Oct 5, 2025
…vers (openai#4689) The `experimental_use_rmcp_client` flag is still useful to: 1. Toggle between stdio clients 2. Enable oauth beacuse we want to land modelcontextprotocol/rust-sdk#469, openai#4677, and binary signing before we enable it by default However, for no-auth http servers, there is only one option so we don't need the flag and it seems to be working pretty well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Many MCP Servers use client_name for a variety of things including:
As a result, it's important for MCP Clients to be able to override the client name.
How Has This Been Tested?
Successfully tested with the Codex CLI talking to the Figma MCP.
Breaking Changes
A new (optional) parameter to AuthorizationSession::new
Types of changes
Checklist
Additional context
This is currently preventing Codex from connecting to the Figma MCP (and likely others)