-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): Add GitHub Search to Github MCP #103
feat(github): Add GitHub Search to Github MCP #103
Conversation
@maheshmurag / @jspahrsummers - please let me know if anything else is needed |
cc. @dsp-ant, couldn't assign a reviewer here, maybe you can help find the right person |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this!
The diff is a bit hard to read with all the formatting changes (please strip those out in future), but the semantic changes look good. Please update from main
so we can merge this.
src/github/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@modelcontextprotocol/server-github", | |||
"version": "0.5.1", | |||
"version": "0.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, all server versions have to be bumped in tandem. Can you please revert this or bump all servers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense, will revert.
Hey, taking a look right now. |
…ervers into add-search-for-github
Re: formatting changes, I do think that we need to add a .prettier config, otherwise my VS Code was just setup by default differently, perhaps. |
Hey @jspahrsummers - I did address your comments + merged with latest master(as there were merge conflicts). Feel free to squash and merge. I did notice that there is no prettierc, so maybe I can add it in a separate PR. Do let me know, if adding some CI for codestyle for TS/python makes sense? I think as you use UV for python, using ruff would make sense. As for TS, I think using prettier/eslint would make most sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes!
w.r.t. linting and styling, I opened #197 to track this. More than happy to review a PR addressing it!
Description
Added comprehensive search functionality to the GitHub MCP Server, enabling users to search for code, issues/PRs, and users across GitHub. This enhancement brings powerful GitHub search capabilities directly to MCP clients.
Server Details
github
tools
(added search functionality),schemas
(added search schemas),documentation
Motivation and Context
GitHub's search functionality is a crucial feature for developers and AI assistants working with codebases. This addition allows MCP clients to:
How Has This Been Tested?
Breaking Changes
No breaking changes. Users can continue using existing functionality without modification. The new search features are purely additive.
Types of changes
Checklist
Additional context