Skip to content

Fix method name in client cancellation send #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Nov 28, 2024

The server registers a notification handler on CancelledNotificationSchema, but is never called on client cancellation because of a mismatch in the method name. This fixes that mismatch.

Motivation and Context

Cancellation between server <-> client implementations does not seem to function correctly. There's no propagation of an abort signal from the client to the server.

How Has This Been Tested?

I made this change in the dependency tree of a local application and saw that the server signal is properly canceled after the change.

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The server registers a notification handler on `CancelledNotificationSchema`, but is never called on client cancellation because of a mismatch in the method name. This fixes that mismatch.
@jspahrsummers
Copy link
Member

Very good catch, thank you!

@jspahrsummers jspahrsummers merged commit becd787 into modelcontextprotocol:main Dec 2, 2024
@efritz efritz deleted the patch-1 branch December 5, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants