Fix method name in client cancellation send #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server registers a notification handler on
CancelledNotificationSchema
, but is never called on client cancellation because of a mismatch in the method name. This fixes that mismatch.Motivation and Context
Cancellation between server <-> client implementations does not seem to function correctly. There's no propagation of an abort signal from the client to the server.
How Has This Been Tested?
I made this change in the dependency tree of a local application and saw that the server signal is properly canceled after the change.
Breaking Changes
Types of changes
Checklist
Additional context