fix: change Icon.sizes from string to string[] #981
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Icon schema to match the MCP specification, which defines sizes as an array of strings rather than a single string. This allows icons to specify multiple size variants (e.g., ["48x48", "96x96"]). Also updates the example usage in simpleStreamableHttp.ts to use the new array format.
felixweinberger
approved these changes
Sep 29, 2025
|
Note for Thursday release review: I believe this is technically a breaking change, so we'll probably need to do a minor version bump here. Given we're improving spec compliance and this is part of a draft spec, I believe we don't need to do anything more significant than that. |
felixweinberger
added
the
improves spec compliance
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to fix failing CI checks on main
Summary
Updates the
Icon.sizesproperty fromstringtostring[]to match the MCP specification.The spec defines
sizesas an array of strings (e.g.,["48x48", "96x96"]or["any"]) rather than a single string. This change:IconSchemainsrc/types.tsto usez.array(z.string())instead ofz.string()simpleStreamableHttp.tsThis resolves type compatibility issues with the spec and allows icons to properly specify multiple size variants.