[bugfix] add tools fileds in inputs2reqeusts

[hjh0119]

fix tools filed None when inputs2request in server mode

[gemini-code-assist]

Summary of Changes

Hello @hjh0119, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This bugfix PR addresses an issue where the 'tools' field was not correctly handled by the inputs2request function in server mode, leading to None values. The fix involves adding 'tools' to the REQUEST_METADATA_FIELDS list in swift/trainers/rlhf_trainer/grpo_trainer.py to ensure it's properly recognized and processed.

Highlights

• Intent: This pull request aims to fix a bug where the 'tools' field was None when the inputs2request function was used in server mode. The fix ensures that the 'tools' field is properly recognized and processed.
• Changes: The primary change involves modifying the swift/trainers/rlhf_trainer/grpo_trainer.py file. Specifically, the REQUEST_METADATA_FIELDS list on line 2516 has been updated to include 'tools', ensuring that this field is considered a core metadata field for requests.
• Reviewer Activity: No specific reviewer activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

Thank you for this bugfix. The change is correct and addresses the issue described. I've added one suggestion to improve the maintainability of the code and prevent similar issues in the future.

[gemini-code-assist]

While this change correctly adds the tools field, hardcoding the list of fields is brittle and likely led to this bug. To improve maintainability and prevent future omissions if RolloutInferRequest or InferRequest are modified, I suggest generating this list dynamically from the dataclass definitions.

This makes the code more robust against future changes to the dataclasses.

Suggested change

	REQUEST_METADATA_FIELDS = ['messages', 'images', 'audios', 'videos', 'tools', 'objects', 'uuid']
	request_fields = set(RolloutInferRequest.__annotations__.keys()) | set(InferRequest.__annotations__.keys())
	REQUEST_METADATA_FIELDS = list(request_fields - {'data_dict'})