feat(rollup-plugin-html): include video and source assets #1008
Conversation
🦋 Changeset detectedLatest commit: c845409 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jorenbroekema
force-pushed
the
feat/video-source
branch
from
abd8e46 to
c845409
Compare
| const asset = getAsset(output, name); | ||
| console.log(asset, name); | ||
| expect(asset).to.exist; | ||
| expect(asset.source).to.exist; |
There was a problem hiding this comment.
Yeah just for debugging purposes, this test is failing in a very strange way, suddenly it cannot find the image-c asset as soon as I add image-d (poster attr for video). And I have no idea why 😭 I tried to play around with it and change stuff around but this bug keeps happening.
|
I think I need some help with this PR, I cannot figure out why the tests are failing. As soon as I add image-d (poster attr for video), suddenly it cannot find the image-c asset, and I can't figure out why it behaves that way :\ I kinda need this PR for my site which uses |
|
@jorenbroekema maybe this PR #1541 meets your needs for |
|
@gdbaldw yep, very nice. I still think this PR should be done at some point to make those tags work by default without needing to specify them manually, since they are native html tags that contain a reference to an asset, but I've given up making the flaky test work :P so your PR will at least enable me to extract those video assets |
No description provided.