Upgrade TypeScript to 4.7.4 #2032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrades related ESLint plugins
🦋 Changeset detectedLatest commit: c26d373 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @justinfagnani; I tried solving the merge conflict but am getting CI errors now 😬 |
|
I very annoyingly ain't getting these failures locally 😭 This PR might get a bit noisy if I keep trying to debug this against CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrades related ESLint plugins
What I did
yarn install -D typescript@latest -W~since TypeScript doesn't follow semvera. Most were cause by catch parameters (
error) being unknown. I cast these to specific Error types when possible.b. One set of errors was around very dynamic console patching that wasn't very type safe to begin with.
I'm unsure whether the upgraded
tscwill cause .d.ts changes that are backwards incompatible. This should be checked before merging. It's possible, because I needed to upgrade TypeScript to be able to upgrade parse5, since parse5 7.0 usestypeimports that TypeScript 4.1 can't parse.