Delete prefix requirement for appIndex redirect. #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue modernweb-dev#1334 for context.
|
|
Gentle ping regarding this PR. Anyone willing to merge this? |
|
Is there anything I can do to bring attention to this pull request? I think it's relatively simple and would fix a problem for at least two users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1334 for context.
This removes the requirement that the devserver see the appIndex relative path at the beginning of the url path in order for the devserver to redirect to the index page. As a developer, I'd expect any page that does not match a URL redirect to the index.html file. This is especially helpful for monorepos where the appIndex file ends up pointing to /packages/example/dev/index.html.