Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
8bae108
TEST-#2966: add script for testing docs
anmyachev Apr 9, 2021
d55e0b3
TEST-#2966: add check docs in asv_bench
anmyachev Apr 9, 2021
7b69b00
TEST-#2966: use return code
anmyachev Apr 9, 2021
6425a9e
TEST-#2966: code style fix
anmyachev Apr 9, 2021
24abf33
TEST-#2966: test work with decorators
anmyachev Apr 12, 2021
34c500d
TEST-#2966: update doc style in asv_bench
anmyachev Apr 12, 2021
de4768e
TEST-#2966: address review comments
anmyachev Apr 12, 2021
c15dc87
TEST-#2966: add linter check for scripts folder
anmyachev Apr 12, 2021
c8c7ceb
TEST-#2966: remove recursive computing
anmyachev Apr 12, 2021
25bbf24
TEST-#2966: Update scripts/doc-checker.py
anmyachev Apr 12, 2021
367e66b
TEST-#2966: use argparse insteod of click
anmyachev Apr 12, 2021
9515aae
TEST-#2966: add docstrings
anmyachev Apr 12, 2021
a70e051
TEST-#2966: add monkeypatching
anmyachev Apr 12, 2021
16c23a2
TEST-#2966: fix --use-numpydoc option
anmyachev Apr 12, 2021
e83272f
TEST-#2966: fix key error
anmyachev Apr 12, 2021
69e9544
TEST-#2966: Apply suggestions from code review
anmyachev Apr 13, 2021
384e0dc
TEST-#2966: address review comments 2
anmyachev Apr 13, 2021
60f24b6
TEST-#2966: change is_failed -> is_successfull
anmyachev Apr 13, 2021
5b96f2a
TEST-#2966: fix
anmyachev Apr 13, 2021
1f8fc26
TEST-#2966: Apply suggestions from code review
anmyachev Apr 14, 2021
1c87459
TEST-#2966: remove GL04, EX04 codes
anmyachev Apr 14, 2021
e54c9ad
TEST-#2966: enable GL08, SS03, PR01, PR02 codes
anmyachev Apr 14, 2021
1e156e2
TEST-#2966: add check of path locations
anmyachev Apr 14, 2021
51a4b8e
TEST-#2966: update asv files for docs check
anmyachev Apr 14, 2021
fcfabfc
TEST-#2966: fix
anmyachev Apr 15, 2021
d46b6c6
TEST-#2966: enable PR08, PR09 checks
anmyachev Apr 15, 2021
97a09ef
TEST-#2966: improve support of noqa; custom check optional args
anmyachev Apr 15, 2021
d10ba2f
TEST-966: fix module case
anmyachev Apr 15, 2021
e4b46b4
TEST-#2966: add spelling check
anmyachev Apr 15, 2021
964f39f
TEST-#2966: simplify code
anmyachev Apr 15, 2021
af1265e
TEST-#2966: add header to doc-checker.py
anmyachev Apr 15, 2021
04dce7a
TEST-#2966: fix regexp
anmyachev Apr 15, 2021
82f9449
TEST-#2966: rename script
anmyachev Apr 15, 2021
277a653
TEST-#2966: add tests
anmyachev Apr 15, 2021
feb038a
TEST-#2966: improve noqa handling
anmyachev Apr 15, 2021
f8ec155
TEST-#2966: install pytest-cov
anmyachev Apr 15, 2021
fc46459
TEST-#2966: install modin in CI
anmyachev Apr 15, 2021
55d4a17
TEST-#2966: Apply suggestions from code review
anmyachev Apr 16, 2021
3479121
TEST-#2966: remove update_results
anmyachev Apr 16, 2021
e181bc7
TEST-#2966: add comment for mapping error codes
anmyachev Apr 16, 2021
8a24ee7
TEST-#2966: remove modin installation
anmyachev Apr 16, 2021
67c8ef6
TEST-#2966: fix usage pathlib.Path with subprocess for python 3.7
anmyachev Apr 16, 2021
c2cb515
TEST-#2966: test
anmyachev Apr 16, 2021
fa67b9d
TEST-#2966: fixes
anmyachev Apr 16, 2021
e91f5d9
TEST-#2966: Update scripts/doc_checker.py
anmyachev Apr 16, 2021
ddbddfa
TEST-#2966: property workaround
anmyachev Apr 16, 2021
51b9ac2
TEST-#2966: skip GL08 error check for __init__
anmyachev Apr 16, 2021
263346e
TEST-#2966: address review comments
anmyachev Apr 16, 2021
63ff426
TEST-#2966: Update scripts/doc_checker.py
anmyachev Apr 17, 2021
eb1aba5
TEST-#2966: add spelling check for 'Ray' and'Dask'
anmyachev Apr 19, 2021
aa60661
TEST-#2966: fix monkeypatching ray.remote
anmyachev Apr 19, 2021
4c5668a
TEST-#2966: fix case when import like: engines/python/__init__.py
anmyachev Apr 19, 2021
c8137cd
TEST-#2966: fix monkeypatching ray.remote
anmyachev Apr 19, 2021
34fc38e
TEST-#2966: add spelling check for 'PyArrow', 'OmniSci', 'XGBoost'
anmyachev Apr 19, 2021
832b88f
TEST-#2966: Apply suggestions from code review
anmyachev Apr 19, 2021
a7a14de
TEST-#2966: show 'NUMPYDOC OUTPUT' only if error appeared
anmyachev Apr 19, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
python-version: "3.7.x"
architecture: "x64"
- run: pip install black
- run: black --check --diff modin/ asv_bench/benchmarks
- run: black --check --diff modin/ asv_bench/benchmarks scripts/doc_checker.py

lint-pydocstyle:
name: lint (pydocstyle)
Expand All @@ -45,13 +45,32 @@ jobs:
with:
python-version: "3.7.x"
architecture: "x64"
- run: pip install pydocstyle
- run: pydocstyle --convention=numpy --add-ignore=D101,D102,D105 modin/pandas/dataframe.py modin/pandas/series.py modin/pandas/groupby.py modin/pandas/base.py
- run: pydocstyle --convention=numpy --add-ignore=D101,D103,D105 modin/pandas/io.py
- run: pydocstyle --convention=numpy --add-ignore=D101,D102 modin/pandas/series_utils.py
- run: pydocstyle --convention=numpy --add-ignore=D103 modin/pandas/general.py
- run: pydocstyle --convention=numpy modin/pandas/plotting.py modin/pandas/utils.py modin/pandas/iterator.py modin/pandas/indexing.py
- run: pydocstyle --convention=numpy --add-ignore=D100,D104 modin/engines/base/frame
- run: pip install pytest pytest-cov pydocstyle numpydoc
- run: pytest scripts/test
- run: pip install -e .[all]
- run: |
python scripts/doc_checker.py --add-ignore=D101,D102,D105 --disable-numpydoc \
modin/pandas/dataframe.py modin/pandas/series.py \
modin/pandas/groupby.py modin/pandas/base.py
- run: python scripts/doc_checker.py modin/pandas/io.py
- run: |
python scripts/doc_checker.py --add-ignore=D101,D102 --disable-numpydoc \
modin/pandas/series_utils.py
- run: |
python scripts/doc_checker.py --add-ignore=D103 --disable-numpydoc \
modin/pandas/general.py
- run: |
python scripts/doc_checker.py --disable-numpydoc \
modin/pandas/plotting.py modin/pandas/utils.py \
modin/pandas/iterator.py modin/pandas/indexing.py
- run: |
python scripts/doc_checker.py --add-ignore=D100,D104 --disable-numpydoc \
modin/engines/base/frame
- run: |
python scripts/doc_checker.py asv_bench/benchmarks/utils.py \
asv_bench/benchmarks/__init__.py asv_bench/benchmarks/io/__init__.py \
asv_bench/benchmarks/scalability/__init__.py
- run: python scripts/doc_checker.py scripts/doc_checker.py

lint-flake8:
name: lint (flake8)
Expand All @@ -65,7 +84,7 @@ jobs:
python-version: "3.7.x"
architecture: "x64"
- run: pip install flake8 flake8-print
- run: flake8 --enable=T modin/ asv_bench/benchmarks
- run: flake8 --enable=T modin/ asv_bench/benchmarks scripts/doc_checker.py

test-api:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
# ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.

"""Modin benchmarks"""
"""Modin benchmarks."""
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.

"""General modin benchmarks"""
"""General Modin benchmarks."""

# define `MODIN_CPUS` env var to control the number of partitions
# it should be defined before modin.pandas import (in case of using os.environ)
Expand Down
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/io/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
# ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.

"""IO modin benchmarks"""
"""IO Modin benchmarks."""
10 changes: 6 additions & 4 deletions asv_bench/benchmarks/io/csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@
get_shape_id,
)

# ray init
if ASV_USE_IMPL == "modin":
pd.DataFrame([])


class BaseReadCsv:
# test data file can de created only once
Expand All @@ -44,6 +40,9 @@ def setup_cache(self, test_filename="io_test_file"):
return test_filenames

def setup(self, test_filenames, shape, *args, **kwargs):
# ray init
if ASV_USE_IMPL == "modin":
pd.DataFrame([])
self.shape_id = get_shape_id(shape)


Expand Down Expand Up @@ -121,6 +120,9 @@ def setup_cache(self, test_filename="io_test_file_csv_names_dtype"):
return cache

def setup(self, cache, shape, names, dtype):
# ray init
if ASV_USE_IMPL == "modin":
pd.DataFrame([])
file_id = self._get_file_id(shape, dtype)
self.filename, self.names, self.dtype = cache[file_id]

Expand Down
2 changes: 1 addition & 1 deletion asv_bench/benchmarks/scalability/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
# ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.

"""Benchmarks measuring how Modin performance scales when MODIN_CPUS are changed"""
"""Benchmarks measuring how Modin performance scales when MODIN_CPUS are changed."""
Loading