Skip to content

Implement minimum account age requirement and temp blocks #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 24, 2019
Merged

Implement minimum account age requirement and temp blocks #180

merged 31 commits into from
Feb 24, 2019

Conversation

Taaku18
Copy link
Collaborator

@Taaku18 Taaku18 commented Feb 16, 2019 •
edited
Loading

Addresses #175 #120

Added

  • Introduced a new configuration variable account_age for setting a minimum account creation age.
    • Users blocked by this reason will be stored in blocked along with other reasons for being blocked.
    • account_age needs to be an ISO8601 Duration Format (examples: P12DT3H 12 days and 3 hours, P3Y5M 3 years and 5 months PT4H14M999S 4 hours 14 minutes and 999 seconds). https://en.wikipedia.org/wiki/ISO_8601#Durations.

Changed

  • block reason cannot start with System Message: as it is now reserved for internal user blocking.
  • block, like close, now support a block duration (temp blocking).

@kyb3r kyb3r changed the title Initial address of issue #175 Implement minimum account age requirement Feb 16, 2019
fourjr
fourjr requested changes Feb 16, 2019
View reviewed changes
@Taaku18 Taaku18 changed the title Implement minimum account age requirement Implement minimum account age requirement and temp blocks Feb 17, 2019
fourjr
fourjr requested changes Feb 17, 2019
View reviewed changes
fourjr
fourjr requested changes Feb 23, 2019
View reviewed changes
@fourjr
Copy link
Collaborator

fourjr commented Feb 23, 2019 •
edited
Loading

Merge this ASAP and start working on #186. That should be the highest priority

@Taaku18
Copy link
Collaborator Author

Taaku18 commented Feb 24, 2019

Merge this ASAP and start working on #186. That should be the highest priority

Sure, merge at your discretion.

@Taaku18 Taaku18 requested a review from fourjr February 24, 2019 04:08
fourjr
fourjr approved these changes Feb 24, 2019
View reviewed changes
Copy link
Collaborator

@fourjr fourjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fourjr fourjr merged commit e2774f9 into master Feb 24, 2019
@Taaku18 Taaku18 deleted the age branch May 13, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyb3r kyb3r kyb3r left review comments

@fourjr fourjr fourjr approved these changes

Assignees
No one assigned
Labels
pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taaku18 @fourjr @kyb3r