Skip to content

added fallback category. #303 #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 26, 2019
Merged

added fallback category. #303 #636

merged 4 commits into from
Nov 26, 2019

Conversation

Aloqeely
Copy link
Contributor

No description provided.

@Taaku18 Taaku18 self-requested a review November 16, 2019 09:06
Taaku18
Taaku18 reviewed Nov 17, 2019
View reviewed changes
Taaku18
Taaku18 reviewed Nov 17, 2019
View reviewed changes
Taaku18
Taaku18 requested changes Nov 17, 2019
View reviewed changes
Copy link
Collaborator

@Taaku18 Taaku18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modmail.py contact method contains a reference of threads.create, add an await.

@Aloqeely Aloqeely requested a review from Taaku18 November 22, 2019 15:08
@StephenDaDev StephenDaDev mentioned this pull request Nov 24, 2019
Closed
Taaku18
Taaku18 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Collaborator

@Taaku18 Taaku18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Taaku18 Taaku18 merged commit a0d820b into modmail-dev:development Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taaku18 Taaku18 Taaku18 approved these changes

+1 more reviewer

@whopiyush whopiyush whopiyush left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Aloqeely Aloqeely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aloqeely @whopiyush @Taaku18