revert: dont use local storage for filters on moderation dash #4129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMB11
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DEV-215
This PR removes the usage of
localStoragefor persisting filter and "Sort By" dropdown states on the reports and moderation queue pages to resolve hydration mismatches.The current implementation uses
localStorageto persist filter and sort preferences across page reloads. However, this causes hydration issues where the server-side rendered content doesn't match the client-side state, similar to the issues we've experienced with the tremendous reward images not synchronizing properly with their corresponding cards.The trade-off of losing filter persistence is acceptable given the stability improvements and the fact that these are administrative pages where consistent, predictable behavior is more important than convenience