-
Notifications
You must be signed in to change notification settings - Fork 331
Charge tax on products #4361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Charge tax on products #4361
Conversation
May need to do some tweaks to the approach to price change notifications w.r.t taxes + tax calculation pending some clarifications from product but it's 90% of the way there—ready for review. It's not the cleanest implementation I'll admit but it works and needs to be shipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks sensible enough to try out. I couldn't review or test this too deeply, but I suppose it's better than nothing.
apps/labrinth/migrations/20250915212454_tax-change-notification.sql
Outdated
Show resolved
Hide resolved
There was an issue with my approach to notify users about price changes (wouldn't notify users if the sales tax rate in their jurisdiction changes) so I ended up modifying this PR quite a bit and fixed some of the implementation issues with it:
Still waiting on the tax-notification email on prod. Requesting review again since the changes are significant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks noticeably better now! 🎉
Integrates with Anrok.
While at it this also massively cleans up the code handling
PaymentIntent
s, and fixes a bug where the intent metadata wasn't being updated when updating the intent via/_internal/billing/payment
.Merging of this is blocked by #4338, so we can implement email notifications before charging people taxes.
Still left to do:
payments
module everywhereproducts_tax_identifiers