pop outside iterator

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
modularml · May 18, 2024 · 6846af8 · 6846af8
1 parent 80afb8a
commit 6846af8
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/stdlib/src/collections/dict.mojo b/stdlib/src/collections/dict.mojo
@@ -716,11 +716,17 @@ struct Dict[K: KeyElement, V: CollectionElement](
             "KeyError" if the dictionary is empty.
         """
 
+        var key = Optional[K](None)
+        var val = Optional[V](None)
+
         for item in reversed(self.items()):
-            var key = item[].key
-            var value = item[].value
-            _ = self.pop(key)
-            return DictEntry[K, V](key, value)
+            key = Optional(item[].key)
+            val = Optional(item[].value)
+            break
+
+        if key:
+            _ = self.pop(key.value()[])
+            return DictEntry[K, V](key.value()[], val.value()[])
 
         raise "KeyError"