[stdlib] Use ValueDestructorRecorder in test_inline_list.mojo
#3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Jun 25, 2024
…t.mojo` (#42108) [External] [stdlib] Use `ValueDestructorRecorder` in `test_inline_list.mojo` This PR is a small piece of mojo#2965 . I'm trying to make mojo#2965 smaller to make it easier to work on. In itself, this PR is a refactoring. The goal is to unify the "destructor counters" that are present in the unit tests and use only the one in `stdlib/test/test_utils/types.mojo`. The goal of those structs is to record the number of `__del__` call being made to make sure the lifecycle of elements in a collection is correct. To make it usable with `InlineList`, I had to add the explicit copy constructor. Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes #3094 MODULAR_ORIG_COMMIT_REV_ID: 4ff2d0ea67c29b144b6c76d3fb0f8db93143e41a
|
Landed in 65c13cd! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Sep 13, 2024
…t.mojo` (#42108) [External] [stdlib] Use `ValueDestructorRecorder` in `test_inline_list.mojo` This PR is a small piece of mojo#2965 . I'm trying to make mojo#2965 smaller to make it easier to work on. In itself, this PR is a refactoring. The goal is to unify the "destructor counters" that are present in the unit tests and use only the one in `stdlib/test/test_utils/types.mojo`. The goal of those structs is to record the number of `__del__` call being made to make sure the lifecycle of elements in a collection is correct. To make it usable with `InlineList`, I had to add the explicit copy constructor. Co-authored-by: Gabriel de Marmiesse <gabriel.demarmiesse@datadoghq.com> Closes #3094 MODULAR_ORIG_COMMIT_REV_ID: 4ff2d0ea67c29b144b6c76d3fb0f8db93143e41a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small piece of #2965 . I'm trying to make #2965 smaller to make it easier to work on.
In itself, this PR is a refactoring. The goal is to unify the "destructor counters" that are present in the unit tests and use only the one in
stdlib/test/test_utils/types.mojo. The goal of those structs is to record the number of__del__call being made to make sure the lifecycle of elements in a collection is correct. To make it usable withInlineList, I had to add the explicit copy constructor.@ConnorGray since you already did a review of #2965