[stdlib] Refactor atol: StringRef to StringSlice and reusability
#3207
+141
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soraros
reviewed
Jul 9, 2024
jjvraw
commented
Jul 12, 2024
jjvraw
changed the title
atol for reusability
jjvraw
force-pushed
the
refact/atol
branch
3 times, most recently
from
5b8b424
to
05740d2
Compare
jjvraw
changed the title
atol: StringRef to StringSlice and reusability
- StringRef to StringSlice - Introduce _handle_base_prefix & _trim_and_handle_sign - Changed var to alias Signed-off-by: Joshua James Venter <venter.joshua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modularises previously inline code, assisting in addressing issue #2639 to allow
stolfunction to reuse some of the functionality. These changes, initially part of PR #3178, have been separated for easier review.The refactoring extracts
_handle_base_prefix&_trim_and_handle_sign. Additionally, the docstring has been revised for clarity.Alongside these changes, the respective function signatures have been updated to move away from
StringReftoStringSlice.There was also a small
FIXMEto convert fromvartoalias, which is now seems possible.