Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use build scripts from CI workflows #3268

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

JoeLoser
Copy link
Collaborator

In #3234, when synced internally, only the scripts were added. The modifications to the GitHub workflow didn't land in b939aea since the .github directory isn't managed by Copybara currently.

So, this PR does the .github workflow cleanup part of #3234 now that b939aea has landed.

In modularml#3234, when synced internally, only the
`scripts` were added.  The modifications to the GitHub workflow didn't land in
modularml@b939aea
since the `.github` directory isn't managed by Copybara currently.

So, this PR does the `.github` workflow cleanup part of
modularml#3234 now that
modularml@b939aea
has landed.

Signed-off-by: Joe Loser <joeloser@fastmail.com>
Copy link
Collaborator

@ConnorGray ConnorGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for doing this manually. Hopefully we'll catch it next time.

@JoeLoser
Copy link
Collaborator Author

Makes sense, thanks for doing this manually. Hopefully we'll catch it next time.

I have an open Linear issue internally to sync the .github directory with Copybara FYI.

@JoeLoser JoeLoser merged commit 3ba4f93 into modularml:nightly Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants