Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] normalize_index() usage within List type. #3400

Closed
wants to merge 1 commit into from
Closed

[stdlib] normalize_index() usage within List type. #3400

wants to merge 1 commit into from

Conversation

vguerra
Copy link
Contributor

@vguerra vguerra commented Aug 20, 2024

Reducing boilerplate code for bounds checking by using normalize_index() utility function.

Partially solves #2948

@vguerra
[stdlib] normalize_index() usage within List type.
183c1b7 
Reducing boilerplate code for bounds checking by using
`normalize_index()` utility function.

Partially solves modularml#2948

Signed-off-by: Victor Guerra <vguerra@gmail.com>
@vguerra vguerra requested a review from a team as a code owner August 20, 2024 11:52
@vguerra vguerra mentioned this pull request Aug 20, 2024
Open
8 tasks
@jjvraw
Copy link
Contributor

jjvraw commented Aug 23, 2024

FYI, this may be a duplicate PR. See #3030 and #3031

@vguerra
Copy link
Contributor Author

vguerra commented Aug 27, 2024

FYI, this may be a duplicate PR. See #3030 and #3031

thanks for raising this, I completely missed those. Abandoning this.

@vguerra vguerra closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vguerra @jjvraw