Skip to content

Conversation

ScriptedAlchemy
Copy link
Member

Summary

  • replace the manifest e2e GitHub step with a script that watches the serve process so background exits bubble up
  • add manifest:e2e scripts to package.json for reuse locally and in CI
  • ensure serve cleanup/kill-port runs deterministically even when Nx dies

Testing

  • node tools/scripts/run-manifest-e2e.mjs --mode=invalid

Copy link

changeset-bot bot commented Sep 27, 2025

⚠️ No Changeset found

Latest commit: a75a044

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit a75a044
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68e60fce3b1cde000819592b
😎 Deploy Preview https://deploy-preview-4106--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ScriptedAlchemy ScriptedAlchemy merged commit fc6b70c into main Oct 8, 2025
18 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the improve-manifest-e2e branch October 8, 2025 09:37
@2heal1 2heal1 mentioned this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant