Skip to content

Ensure shared context library is shared as singleton #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2025
Merged

Ensure shared context library is shared as singleton #4387

merged 2 commits into from
Sep 20, 2025
+32 −18

Conversation

ScriptedAlchemy
Copy link
Member

Summary

  • share the NameContextProvider library from app1 and app2 as a singleton to avoid duplicate context instances
  • mark the React dependencies as singletons so the host and remote use the same copy during tests

Testing

  • pnpm e2e

https://chatgpt.com/codex/tasks/task_e_68ce4c370d648325a92ede7dc32a9d8b

@ScriptedAlchemy ScriptedAlchemy merged commit ae8b6b0 into mass-conversion Sep 20, 2025
2 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the codex/fix-failing-e2e-test-in-example branch September 20, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScriptedAlchemy