will there be a version for modx 3?

[ssl1984]

Feature request

Summary

Quick summary what's this feature request about.

Why is it needed?

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Suggested solution(s)

A clear and concise description of what you want to happen.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request.

[JoshuaLuckers]

Support for 3.x is a work in progress. Any help is welcome, you can use the develop branch to help test and submit issues and/or PR's!

[rthrash]

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/need-help-with-mystery-connector-500-error/4978/6

[BobRay]

The error Ryan is talking about caused a completely empty resource tree. Commenting out the three "require_once" lines in the ArticlesContainer class fixed that (though Articles itself still doesn't work).

[Mark-H]

That's probably been fixed with aaba113 but there hasn't been a release yet I think.

[JoshuaLuckers]

Any help with testing the things that are already done in the develop branch that would be great! Especially for those upgrading from an existing installation with Articles. But always make a backup!

[JoshuaLuckers]

I had some time today to look into 3.x compatibility. I pushed some changes to the develop branch, installing it in 3.x still gives some errors. Most likely related to the validators in _build/resolvers/validators:

Could not get table class for class: modTransportPackage

Could not get table name for class: modTransportPackage

If someone knows a fix for this, please feel free to submit a PR. Otherwise I'll look into it myself sometime in the upcoming week.

[JoshuaLuckers]

Thanks to @Mark-H I've solved the issue with the resolvers and validators.

There is still some work to do:

• Quip isn't ready for 3.x yet and therefore can't be installed.
• Load the Articles service using bootstrap.php since extension_packages is no longer being used in 3.x

[JoshuaLuckers]

The ArticlesContainer isn't recognized as Document Type yet. So I have to fix that as well.

Probably because the schema is still for 2.x, but I want to maintain backwards compatibility with 2.x without releasing a separate version for 3.x.
Any suggestions are welcome!

[muzzwood]

Hey @JoshuaLuckers 👋🏻
I was playing around trying to get the Articles derivative modResource classes to be loaded in both 2.x and 3.x but haven't had much luck. 😅

It could be that having a separate version for 3.x is the easier (possible) path... if you're open to it?
The main consideration I think would be to make sure the current version doesn't cause any errors during an upgrade from MODX 2.x -> 3.x, and then the user would upgrade to the 3.x version via the package manager after the MODX upgrade is complete.

What do you reckon?

[JoshuaLuckers]

@muzzwood Thanks a lot for taking time to help out!

It could be that having a separate version for 3.x is the easier (possible) path... if you're open to it?
The main consideration I think would be to make sure the current version doesn't cause any errors during an upgrade from MODX 2.x -> 3.x, and then the user would upgrade to the 3.x version via the package manager after the MODX upgrade is complete.

That seems like a good enough solution for me!

[muzzwood]

Awesome! I'll get a PR together for you ;)

[muzzwood]

WIP draft is here #156
Can't be packaged yet but I hope to get that done later today.

[JoshuaLuckers]

@muzzwood I've merged your PR. I'll try to update the changelog tomorrow and submit an alpha release of it.

[BobRay]

Great work guys!

[JoshuaLuckers]

Sorry guys I didn't manage to put out a new release. I hope to do it soon. @muzzwood but feel free to put out a new release if you have more time for it.