Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dot followed by space in directories #16578

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Jun 14, 2024

What does it do?

Refined regex in Browser class to allow dot-space (e.g., 1. Folder Name) within directory, but not when directory/file begins with a dot (e.g., .htaccess, .hidden-dir, etc).

Why is it needed?

Responding to community member request.

How to test

Create various directories and files with dot(s) and space(s) within to verify desired behavior.

Related issue(s)/PR(s)

Resolves #16351

@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Jun 17, 2024
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as described :)

@opengeek opengeek merged commit 46d232e into modxcms:3.x Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filesystem stripping periods from folder names
3 participants