Add Help! label to Menu Item #16586
Merged
Add Help! label to Menu Item #16586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Help! label to the Help Menu Item that was previously represented by the just an icon. This was to fix for modxcms#13485
|
I don't know if this needs the refactoring due to the PSR level errors as I just followed the code pattern of the original file. Can do if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Help! label to the Help Menu Item that was previously represented by the just an icon.
This was to fix for #13485
What does it do?
Provides accessible label for the Help button in the header #13485
Why is it needed?
The current link has no link text and no value for screen readers
How to test
This may require a build and or rerunning setup.
Related issue(s)/PR(s)
Should resolve #13485 by adding aria-label and corresponding text via lexicon to the
aof the Help button in the header.